Distinguishing suggestions from global scope from local suggestions

From https://github.com/Microsoft/vscode/issues/59437 <!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. --**TypeScript Version:** 3.2.0-dev.20180928 <!-- Search terms you tried before logging this (so others can find this issue more easily) --> **Search Terms:** - TSServer - completions - suggestions **Code** For the example ts file: ```ts class FooClass { toString(): void { | } } ``` Trigger suggestions at the `|` inside the `toString` method **Problem** We get back two completions from `completionInfo`: ```json { "name": "toString", "kind": "function", "kindModifiers": "declare", "sortText": "0" }, { "name": "toString", "kind": "method", "kindModifiers": "", "sortText": "0", "insertText": "this.toString" }, ``` However when we then make the `completionEntryDetails` request, we can only pass the identifier name: `"toString"`. This makes it unclear which completion entry we are actually requesting completion details for. **Proposal** `completionEntryDetails` already has a `source` field that is used to identify when a suggestion is an auto import. I believe that this field could also be used for global symbols, such as when a symbol name comes from a global `lib.d.ts` file. In this case, the first `toString` suggestion comes from a global in `dom.d.ts`