`aadd_texts() got multiple values for keyword argument 'ids'`

(rewritten by @mdrxy) `aadd_documents()` raises `TypeError` when passing custom document IDs ```python documents = [ Document(page_content="Hello world"), Document(page_content="Goodbye world"), ] ids = ["doc_1", "doc_2"] # This fails await vector_store.aadd_documents(documents, ids=ids) ``` --- Original: ### Checked other resources - [x] This is a bug, not a usage question. For questions, please use the LangChain Forum (https://forum.langchain.com/). - [x] I added a clear and descriptive title that summarizes this issue. - [x] I used the GitHub search to find a similar question and didn't find it. - [x] I am sure that this is a bug in LangChain rather than my code. - [x] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package). - [x] I read what a minimal reproducible example is (https://stackoverflow.com/help/minimal-reproducible-example). - [x] I posted a self-contained, minimal, reproducible example. A maintainer can copy it and run it AS IS. ### Example Code Extend the example I sent in #32195 but try to add documents to the ```` await vs.aadd_documents(docs, ids=ids) ```` This snippet (add documents to a Qdrant Vector Store) will bomb. ### Error Message and Stack Trace (if applicable) aadd_texts() got multiple values for keyword argument 'ids'. ### Description The body of aadd_documents has an if part that is adding ids into kwargs and is also passing it. Python explodes because it is passed explicitly and in kwargs. Here's how I patched it, in the return line: ``` return await self.aadd_texts(texts, metadatas, **kwargs) # @glebs patch: aadd_texts() got multiple values for keyword argument 'ids'. My patch: simply removed ids=ids from the call…